[PATCH] D81645: MIR Statepoint refactoring. Part 1: Basic MI level changes.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 11 20:52:47 PDT 2020
reames added a comment.
LGTM with one minor stylistic question. Can be addressed in separate change if desired.
================
Comment at: llvm/include/llvm/CodeGen/StackMaps.h:170
+ explicit StatepointOpers(const MachineInstr *MI) : MI(MI) {
+ NumDefs = MI->getNumDefs();
+ }
----------------
Since we have MI available, why add a new variable? I'd expect the accessors to just use MI->getNumDefs() directly?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81645/new/
https://reviews.llvm.org/D81645
More information about the llvm-commits
mailing list