[PATCH] D81614: [llvm][llvm-nm] add TextAPI/MachO support

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 19:15:52 PDT 2020


cishida marked 3 inline comments as done.
cishida added a comment.

the landed patch has applied MaskRay's comments.



================
Comment at: llvm/test/Object/Inputs/tapi-invalid-v2.tbd:1
+--- !tapi-tbd-v2
+uuids: [ "armv7: 00000000-0000-0000-0000-000000000000",
----------------
MaskRay wrote:
> Consider moving new `test/Object/*` tests to `test/Object/MachO/*`
Since that directory doesn't exist in the repo currently, I will land a separate NFC commit to move all the machO based nm tests there. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81614/new/

https://reviews.llvm.org/D81614





More information about the llvm-commits mailing list