[PATCH] D81198: [docs] Specify rules for updating debug locations
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 11 18:43:31 PDT 2020
vsk marked 8 inline comments as done.
vsk added inline comments.
================
Comment at: llvm/docs/HowToUpdateDebugInfo.rst:97
+ ``(sext (zext x)) => (zext x)``. The rule for
+ :ref:`preserving locations<WhenToPreserveLocation>` should apply here.
+
----------------
aprantl wrote:
> I would be curious about an explanation what makes this example different from the fma example above.
Thanks for pressing on this, it's not terribly clear as-written. How about: "Block-local peepholes which delete redundant instructions, like ``(sext (zext i8 %x to i16) to i32) => (zext i8 %x to i32)``. The inner ``zext`` is modified but remains in its block, so the rule for preserving locations should apply."
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81198/new/
https://reviews.llvm.org/D81198
More information about the llvm-commits
mailing list