[PATCH] D81700: [MSAN] Under eager-checks, pass Origin by parameter to __msan_warning functions
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 11 17:38:46 PDT 2020
eugenis added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:786
+ // Enable origin as param with eager checks, as a space saving measure.
+ WarningFnTakesOrigin = ClEagerChecks;
+
----------------
This is an unconditional improvement, simply apply it in all cases. Keep __msan_warning_noreturn in the runtime library for backwards compatibility, but never issue a call to it in the instrumentation. Update the tests in test/Instrumentation/MemorySanitizer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81700/new/
https://reviews.llvm.org/D81700
More information about the llvm-commits
mailing list