[PATCH] D81605: IR: Add missing GlobalAlias copying of ThreadLocalMode attribute

Thu Jun 11 15:59:54 PDT 2020

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM. If @hans has any comments they can be addressed in a follow on change. Two things to fix before submitting though:

- A small change to the test comments is needed as noted below before submitting.
- The patch description needs updating. Doesn't need a full test case etc like it currently has, but does just need a general overview of the problem and fix.

================
Comment at: llvm/test/Linker/alias-threadlocal.ll:2
+; RUN: llvm-link %s %p/Inputs/alias-threadlocal-defs.ll -S -o - | FileCheck %s
+; PR81605
+
----------------
Please fix the bug number. https://bugs.llvm.org/show_bug.cgi?id=81605 is not a valid bug. In addition, please add a one sentence description at the top of what this is testing.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81605/new/

https://reviews.llvm.org/D81605