[PATCH] D81692: [flang] add DoLoopHelper

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Looks clear to me. A couple of questions before i can approve.



================
Comment at: flang/lib/Lower/CMakeLists.txt:13
+  MLIRControlFlowInterfaces
+  MLIRLinalgStructuredOpsInterfaceIncGen
+
----------------
Is this is for a future patch?

Why is there no FIR dependency here?


================
Comment at: flang/lib/Lower/DoLoopHelper.cpp:22
+  auto inc = builder.convertToIndexType(loc, step);
+  auto loop = builder.create<fir::LoopOp>(loc, lbi, ubi, inc);
+  auto insertPt = builder.saveInsertionPoint();
----------------
What is the story for down counting loops? Where are these handled? can the FIR loop dow count?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81692/new/

https://reviews.llvm.org/D81692