[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added a comment.

I like this in principle. Makes a lot more sense to control this directly from clang than to rely on function attributes.



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriterPass.cpp:31
+                       EmitModuleHash);
+  }
   return PreservedAnalyses::all();
----------------
What does this chunk do?


================
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:456
+    function_ref<AAResults &(Function &)> AARGetter, Module &M,
+    function_ref<ModuleSummaryIndex()> IndexGetter,
+    function_ref<const StackSafetyInfo *(const Function &)> SSIGetter) {
----------------
Why do you need to turn ModuleSummaryIndex into a getter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81244/new/

https://reviews.llvm.org/D81244