[PATCH] D81662: [NFC] Use ADT/Bitfields in Instructions

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/IR/Instructions.h:531
+  using VolatileField = Bitfield<bool, 0, 1>;                  // Next bit:1
+  using SuccessOrderingField = Bitfield<AtomicOrdering, 2, 3>; // Next bit:5
+  using FailureOrderingField = Bitfield<AtomicOrdering, 5, 3>; // Next bit:8
----------------
gchatelet wrote:
> The bit in position `1` is unused?
It used to be syncscope before that was extended to support arbitrary scopes instead of just single thread and system


================
Comment at: llvm/include/llvm/IR/Instructions.h:720
+  using VolatileField = Bitfield<bool, 0, 1>;
+  using AtomicOrderingField = Bitfield<AtomicOrdering, 2, 3>;
+  using OperationField = Bitfield<BinOp, 5, 4>;
----------------
gchatelet wrote:
> Same here the bit in position `1` is unused.
Same as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81662/new/

https://reviews.llvm.org/D81662