[PATCH] D81050: [llvm-exegesis] Let Counter returns up to 16 entries.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp:98
+
+  switch (ResultAggMode) {
+  case InstructionBenchmark::MinVariance: {
----------------
ondrasej wrote:
> I'd still split this into two arguments:
> One that decides what happens with the return values of runAndSample() with {Concatenate, MinVariance}.
> 
> And another one that decides what to do with the results of the previous step (Min, Max, Mean, return as is}.
> 
> With the current MinVariance filtering in all cases, we're changing the behavior for scalar counters, where we might drop some values (and we might drop some values also in the LBR case).
Ah, I think we can infer how to accumulate the values returnt by runAndSample().

* If the return vector has more than 1 element, then keep the set with min variance (because it wouldn't make sense to concat all the values from different runs together)
* If the vector only has 1 element,  then concat them together to find Min/Max/Mean




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81050/new/

https://reviews.llvm.org/D81050