[PATCH] D81614: [llvm][llvm-nm] add TextAPI/MachO support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2111
+      if (auto ObjOrErr = I.getAsObjectFile()) {
+        TapiFile &Obj = *ObjOrErr.get();
+        outs() << "\n"
----------------
Obj is only used once. Inline the variable to the call site


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:2116
+        dumpSymbolNamesFromObject(Obj, false, {}, ArchName);
+      } else if (auto E =
+                     isNotObjectErrorInvalidFileType(ObjOrErr.takeError())) {
----------------
auto -> Error


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81614/new/

https://reviews.llvm.org/D81614