[PATCH] D81582: [BreakCritEdges] Check if we need to split blocks with indirectbr terms.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 11:33:50 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp:193
+      if (any_of(LoopPreds, [](BasicBlock *Pred) {
+            return isa<IndirectBrInst>(Pred->getTerminator());
+          })) {
----------------
Really, I'd prefer if the `if (Options.PreserveLoopSimplify) return nullptr;` check wasn't guarded by the check for indirectbrinsts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81582/new/

https://reviews.llvm.org/D81582





More information about the llvm-commits mailing list