[PATCH] D79785: [ARM] Register pressure with -mthumb forces register reload before each call

[John Brawn via Phabricator via llvm-commits]

john.brawn added a comment.

Changes look OK, though as I said before please add tests for this.



================
Comment at: llvm/lib/Target/ARM/Thumb1InstrInfo.cpp:177-181
+    for (auto &MO: MI.implicit_operands())
+      if (MO.isReg())
+        MIB.addReg(MO.getReg(), RegState::Implicit | RegState::Kill);
+      else if (MO.isRegMask())
+        MIB.add(MO);
----------------
I think here you can just call MIB.add(M0) for all of the implicit operands of MI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79785/new/

https://reviews.llvm.org/D79785