[PATCH] D81584: [BreakCritEdges] Support preserving loop-simplify form with indirectbr. (WIP)

Thu Jun 11 11:00:31 PDT 2020

fhahn added a comment.

In D81584#2086602 <https://reviews.llvm.org/D81584#2086602>, @efriedma wrote:

> > I think in the short-term, it might be best to add a PreserveLoopSimplify option and have GVN not preserve loop-simplify form, until this patch is ready. What do you think?
>
> That seems reasonable.  I'm not sure why GVN is trying to preserve LoopSimplify in the first place.

I think it was because I initially *thought* all the utilities used to modify the CFG actually preserve loop-simplify form. I updated D81582 <https://reviews.llvm.org/D81582> with the option & made GVN use it. It would be great if you could take a look.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81584/new/

https://reviews.llvm.org/D81584