[PATCH] D81590: [llvm-objdump] Decrease instruction indentation for non-x86

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D81590#2086917 <https://reviews.llvm.org/D81590#2086917>, @jhenderson wrote:

> Seems reasonable to me. I take it we don't have any supported targets with 64-bit instructions (or at least more than 32-bits)? Similarly, I assume GNU indents to the same width for e.g. thumb 16-bit instructions as well as 32-bit instructions?
>
> I'm happy with us moving towards better GNU compatibility for some targets without breaking it for others.


Added an example of thumb in the description. The instruction is also placed at the 24th column.

Power ISA v3.1 introduced 64-bit instructions. GNU objdump will not change the column of instructions:

  0000000000000000 <.text>:
     0:   00 00 10 04     plwa    r3,0
     4:   00 00 60 a4 
     8:   00 00 10 04     plwa    r3,0
     c:   00 00 60 a4 

It seems we don't have good support for these instructions now. (Changing the column will not alter their display if we want to use multi-line..)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81590/new/

https://reviews.llvm.org/D81590