[PATCH] D81628: [WebAssembly] Make BR_TABLE non-duplicable
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 11 05:26:56 PDT 2020
aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
LGTM either with `isNotDuplicable` or `isConvergent`, as long as it works. I'm not familiar with what `isConvergent` is used for either, so..
Just to confirm, this is separate from why final.c in https://bugs.chromium.org/p/v8/issues/detail?id=10606 is slow, right?
================
Comment at: llvm/test/CodeGen/WebAssembly/indirectbr.ll:30
; CHECK: end_loop
+; CHECK: end_function
; CHECK: test1.targets:
----------------
Were we duplicating `br_table` even for this simple example? Is that why the test result changed?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81628/new/
https://reviews.llvm.org/D81628
More information about the llvm-commits
mailing list