[llvm] 9ed452f - [llvm/DWARFDebugLine] Remove spurious full stop from warning messages

[Pavel Labath via llvm-commits]

Author: Pavel Labath
Date: 2020-06-11T13:14:21+02:00
New Revision: 9ed452f3701ec225b9e3296d5ab244fec6699fdf

URL: https://github.com/llvm/llvm-project/commit/9ed452f3701ec225b9e3296d5ab244fec6699fdf
DIFF: https://github.com/llvm/llvm-project/commit/9ed452f3701ec225b9e3296d5ab244fec6699fdf.diff

LOG: [llvm/DWARFDebugLine] Remove spurious full stop from warning messages

Other warnings messages don't have a trailing full stop.

Added: 
    

Modified: 
    llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
    llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
index 2faee15bc045..df9a496cf57f 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
@@ -275,14 +275,14 @@ parseV5DirFileTables(const DWARFDataExtractor &DebugLineData,
         if (!Value.extractValue(DebugLineData, OffsetPtr, FormParams, &Ctx, U))
           return createStringError(errc::invalid_argument,
                                    "failed to parse directory entry because "
-                                   "extracting the form value failed.");
+                                   "extracting the form value failed");
         IncludeDirectories.push_back(Value);
         break;
       default:
         if (!Value.skipValue(DebugLineData, OffsetPtr, FormParams))
           return createStringError(errc::invalid_argument,
                                    "failed to parse directory entry because "
-                                   "skipping the form value failed.");
+                                   "skipping the form value failed");
       }
     }
   }
@@ -302,7 +302,7 @@ parseV5DirFileTables(const DWARFDataExtractor &DebugLineData,
       if (!Value.extractValue(DebugLineData, OffsetPtr, FormParams, &Ctx, U))
         return createStringError(errc::invalid_argument,
                                  "failed to parse file entry because "
-                                 "extracting the form value failed.");
+                                 "extracting the form value failed");
       switch (Descriptor.Type) {
       case DW_LNCT_path:
         FileEntry.Name = Value;

diff  --git a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
index 0b2116a6c0ab..053063edc2e3 100644
--- a/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
+++ b/llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
@@ -161,7 +161,7 @@
 ## V5 prologue ends during directory table.
 # NONFATAL:      debug_line[0x00000214]
 # SOME-ERR-NEXT: warning: parsing line table prologue at 0x00000214 found an invalid directory or file table description at 0x00000236
-# SOME-ERR-NEXT: warning: failed to parse directory entry because extracting the form value failed.
+# SOME-ERR-NEXT: warning: failed to parse directory entry because extracting the form value failed
 # NONFATAL-NEXT: Line table prologue
 # NONFATAL-NOT:  include_directories
 # VERBOSE:       DW_LNE_set_address (0x4444333322221111)
@@ -170,7 +170,7 @@
 ## V5 invalid MD5 hash form when there is still data to be read.
 # NONFATAL:      debug_line[0x00000244]
 # SOME-ERR-NEXT: warning: parsing line table prologue at 0x00000244 found an invalid directory or file table description at 0x00000277
-# SOME-ERR-NEXT: warning: failed to parse file entry because extracting the form value failed.
+# SOME-ERR-NEXT: warning: failed to parse file entry because extracting the form value failed
 # NONFATAL-NEXT: Line table prologue
 # NONFATAL:      include_directories[  0] = "/tmp"
 # NONFATAL-NOT:  file_names
@@ -190,7 +190,7 @@
 ## V5 invalid directory content description has unsupported form.
 # NONFATAL:      debug_line[0x000002c0]
 # SOME-ERR-NEXT: warning: parsing line table prologue at 0x000002c0 found an invalid directory or file table description at 0x000002e9
-# SOME-ERR-NEXT: warning: failed to parse directory entry because skipping the form value failed.
+# SOME-ERR-NEXT: warning: failed to parse directory entry because skipping the form value failed
 # NONFATAL-NEXT: Line table prologue
 # NONFATAL:      include_directories[  0] = "/foo"
 # NONFATAL-NOT:  include_directories

diff  --git a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
index d01c24a3de89..6a99bbf83ae1 100644
--- a/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
+++ b/llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
@@ -472,7 +472,7 @@ TEST_P(DebugLineParameterisedFixture, ErrorForTooShortPrologueLength) {
                       "of the prologue");
   } else {
     Errs.emplace_back(
-        "failed to parse file entry because extracting the form value failed.");
+        "failed to parse file entry because extracting the form value failed");
   }
   EXPECT_THAT_ERROR(std::move(Recoverable),
                     FailedWithMessageArray(testing::ElementsAreArray(Errs)));