[PATCH] D79369: [InstCombine] "X - (X / C) * C == 0" to "X & C-1 == 0"

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 11 00:01:11 PDT 2020


lebedev.ri added a comment.

In D79369#2086224 <https://reviews.llvm.org/D79369#2086224>, @EgorBo wrote:

> In D79369#2085994 <https://reviews.llvm.org/D79369#2085994>, @lebedev.ri wrote:
>
> > LGTM, thanks you.
> >  If you need help committing this, do specify the "name <e at ma.il>" to be used.
>
>
> @lebedev.ri I'm not sure I understand what you mean, do I need to add a header on top of that diff? something like
>
> From: EgorBo <egorbo at gmail.com>
>
>  ---
>
> ?


https://llvm.org/docs/DeveloperPolicy.html#attribution-of-changes
https://llvm.org/docs/DeveloperPolicy.html#commit-messages

> If you’re not the original author, ensure the ‘Author’ property of the commit is set to the original author and the ‘Committer’ property is set to yourself. You can use a command similar to git commit --amend --author="John Doe <jdoe at llvm.org> to correct the author property if it is incorrect. See Attribution of Changes for more information including the method we used for attribution before the project migrated to git.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79369/new/

https://reviews.llvm.org/D79369





More information about the llvm-commits mailing list