[PATCH] D81230: Correctly report modified status for LoopIdiomRecognize

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 23:12:30 PDT 2020


serge-sans-paille marked an inline comment as done.
serge-sans-paille added a comment.

In D81230#2081245 <https://reviews.llvm.org/D81230#2081245>, @efriedma wrote:

> I'd prefer to conservatively return true, rather than worry about whether calling expandCodeFor and cleaning it up is actually a pure no-op in terms of use-lists etc.


I'm curious about the motivation behind that statement. Existing code already tries to tidy up the code (e.g. line 1084), so I feel I'm just syndicating that code in one place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81230/new/

https://reviews.llvm.org/D81230





More information about the llvm-commits mailing list