[PATCH] D81457: [LLD][PowerPC] Add support for R_PPC64_PCREL34

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/ppc64-pcrel34-reloc.s:3
+
+# RUN: llvm-mc -filetype=obj -triple=powerpc64le-unknown-linux %s -o %t.o
+# RUN: ld.lld %t.o -o %t
----------------
Delete `-unknown-linux` 


================
Comment at: lld/test/ELF/ppc64-pcrel34-reloc.s:21
+glob_int:
+	.long	0                       # 0x0
+	.size	glob_int, 4
----------------
`# 0x0` is unnecessary

ditto below

CHECK lines before the code are more common. (A few ppc64 tests may not follow the convention)


================
Comment at: lld/test/ELF/ppc64-pcrel34-reloc.s:51
+# SYMBOL:      1008a32c     8 NOTYPE  LOCAL  DEFAULT     4 glob_int8_big
+
+
----------------
Delete trailing empty lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81457/new/

https://reviews.llvm.org/D81457