[PATCH] D81537: [PowerPC] Support constrained fp operation for scalar fptosi/fptoui

[Qiu Chaofan via Phabricator via llvm-commits]

qiucf added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8148
+    return DAG.getNode(Opc, dl, VT, Op);
+  assert((!Strict || Chain) && "Missing chain for creating strict nodes");
+
----------------
steven.zhang wrote:
> !Strict is not needed.
If `Strict` is `false`, we can allow Chain to be null.


================
Comment at: llvm/test/CodeGen/PowerPC/fp-strict-conv.ll:171
+
+attributes #0 = { strictfp }
----------------
steven.zhang wrote:
> Does this attribute need ?
> All function calls done in a function that uses constrained floating point intrinsics must have the strictfp attribute.
Although output won't change if we remove this attr. It's better to keep it according to langref.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81537/new/

https://reviews.llvm.org/D81537