[PATCH] D80272: [mlir] Support big-endian systems in DenseElementsAttr (multiple word)

[Haruki Imai via Phabricator via llvm-commits]

imaihal marked 4 inline comments as done.
imaihal added inline comments.


================
Comment at: mlir/lib/IR/Attributes.cpp:566
+      llvm::support::endianness::big) {
+    unsigned numFilledWords = bitWidth / APInt::APINT_BITS_PER_WORD;
+    unsigned resBits = bitWidth - numFilledWords * APInt::APINT_BITS_PER_WORD;
----------------
rriddle wrote:
> This looks identical to below, can you extract into a helper?
Created getAPIntCopyParam() to calculation parameters for copying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80272/new/

https://reviews.llvm.org/D80272