[PATCH] D81614: [llvm][llvm-nm] add TextAPI/MachO support

Cyndy Ishida via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 16:08:17 PDT 2020


cishida marked 4 inline comments as done.
cishida added inline comments.


================
Comment at: llvm/include/llvm/TextAPI/MachO/Architecture.h:50
+/// Check if architecture is 64 bit
+bool is64Bit(Architecture);
+
----------------
JDevlieghere wrote:
> Would `getNumberOfBits` be a more "generic" API? 
I agree but I named that to conform to the MachO api. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81614/new/

https://reviews.llvm.org/D81614





More information about the llvm-commits mailing list