[PATCH] D81429: [COFF] Port CallGraphSort to COFF from ELF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 13:55:55 PDT 2020


MaskRay added a comment.

Parametric generalization on InputSection and Symbol may not be a good idea but they are very different in ELF and COFF. `ICF.cpp` is an example where we could reuse code but we choose not to. 
If it is not clear reusing code will be beneficial, I think we can duplicate code for now. The algorithm is simple and there is not much duplication anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81429/new/

https://reviews.llvm.org/D81429





More information about the llvm-commits mailing list