[PATCH] D81607: BreakCriticalEdges for callbr indirect dests

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked 3 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/test/Transforms/CallSiteSplitting/callsite-split-callbr.ll:13
+; CHECK:       Top.split:
+; CHECK-NEXT:    call void @callee(i1 false)
+; CHECK-NEXT:    br label [[CALLSITEBB:%.*]]
----------------
void wrote:
> nickdesaulniers wrote:
> > noob question: this totally fails for me, even though the test was autogenerated.  FileCheck is complaining that:
> > ```
> > /android0/llvm-project/llvm/test/Transforms/CallSiteSplitting/callsite-split-callbr.ll:13:15: error: CHECK-NEXT: expected string not found in input
> > ; CHECK-NEXT: call void @callee(i1 false)
> >               ^
> > ...
> >            9: Top.split: ; preds = %Top
> > next:13'0                X~~~~~~~~~~~~~ error: no match found
> >           10:  call void @callee(i1 false)
> > next:13'0     ~~~~~~~~~~~~~~~~~~~
> > next:13'1      ?                           possible intended match
> > ...
> > ```
> > which makes no sense to me.  Am I holding it wrong?
> FileCheck should ignore the comment...Try changing
> 
> ```
> CHECK: Top.split:
> ```
> 
> to
> 
> ```
> CHECK-LABEL: Top.split:
> ```
> 
> or add the comment?
That works, thanks @void!

update_test_checks.py tries to change them back though...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81607/new/

https://reviews.llvm.org/D81607