[PATCH] D81109: llvm-link: Add support for archive files as inputs.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

If you think it's not too much work you could add negative test cases for other broken modules, it seems some errors are not hit so far. I also left a high level comment below.

All in all I think this is fine though. I wait a bit for anyone to chime in before I accept this.



================
Comment at: llvm/tools/llvm-link/llvm-link.cpp:209
+}
+
 namespace {
----------------
High level: The code is pretty "unqualified `auto`" heavy. While I guess this is neither performance critical nor too important, I would recommend to either specify some types where it might be helpful and use qualifiers, `const`, `*`, `&` where applicable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81109/new/

https://reviews.llvm.org/D81109