[PATCH] D80206: [IR] Clean up dead instructions after simplifying a conditional branch

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

This looks very reasonable to me.



================
Comment at: llvm/lib/IR/BasicBlock.cpp:343-345
+    if (MaybeDeadInstrs)
+      if (auto *I = dyn_cast<Instruction>(V))
+        MaybeDeadInstrs->push_back(I);
----------------
Nitpick: I think it's better to put braces around multi-line if-guarded statements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80206/new/

https://reviews.llvm.org/D80206