[PATCH] D81236: Correctly report modified status for LoopExtractor
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 10 13:21:31 PDT 2020
jdoerfert added a comment.
> In case the LoopExtractor does nothing, it will report that all analyses are preserved, but the preceding call to BreakCriticalEdges will (and if it doesn't - it should) already report the non preserved analyses.
This is the critical part. Does `BreakCriticalEdges` report a modification, if so the PM should be aware and it might be a PM bug, if not it is a `BreakCriticalEdges` bug. The user, here LoopExtractor, doesn't modify, so it should not check if a requirement did (as that is in general impossible).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81236/new/
https://reviews.llvm.org/D81236
More information about the llvm-commits
mailing list