[PATCH] D81570: [DebugInfo] Don't print extended opcode operands if invalid

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 06:32:13 PDT 2020


jhenderson created this revision.
jhenderson added reviewers: aprantl, JDevlieghere, probinson, dblaikie, MaskRay, ikudrin, labath.
Herald added subscribers: cmtice, hiraditya.
Herald added a project: LLVM.

Previously, if there was an error whilst parsing the operands of an extended opcode, the operands would be treated as zero and printed. This could potentially be slightly confusing. Similar to what has already been done for standard opcodes, this patch disables the printing of the operands if an error has been detected.

Depends on D81562 <https://reviews.llvm.org/D81562>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D81570

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81570.269819.patch
Type: text/x-patch
Size: 7114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200610/290c4265/attachment.bin>


More information about the llvm-commits mailing list