[PATCH] D81517: Extend or truncate __ptr32/__ptr64 pointers when dereferenced.
Hans Wennborg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 10 05:25:42 PDT 2020
hans added a comment.
> which is why this code is in two different places
Could both cases be handled in the place that runs before the legalizer?
Hopefully Craig can take a look too, he's the expert here.
================
Comment at: llvm/test/CodeGen/X86/mixed-ptr-sizes.ll:132
+; X64-LABEL: test_load_sptr32:
+; X64: movslq %ecx, %rax
+define i32 @test_load_sptr32(i32 addrspace(270)* %i) {
----------------
This just shows the sign extension. I would add a check line for the actual load too, to make sure that's correct and also to make the test easier to understand. Same for the tests below.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81517/new/
https://reviews.llvm.org/D81517
More information about the llvm-commits
mailing list