[PATCH] D81544: [LVI] Make use of 'assume'-provided data

[JunMa via Phabricator via llvm-commits]

junparser marked an inline comment as done.
junparser added a comment.

since we still need discuss about the invoke of getValueInBlock, I'll split this patch into two parts.



================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1810
+      return getPredicateResult(Pred, C, Result, DL, TLI);
+    }
+
----------------
nikic wrote:
> This will result in incorrect handling of pointers, as the miscompiles in non-null.ll show. This would need D69914 to be reapplied first. Additionally it doesn't really make sense to limit this to the entry block, this should be using the block value for everything (that would be D69686).
thanks for point this. I have not notice handling of pointers.
As for limit this to entry block. it is the same reason as you mentioned in D69686 (the different order of computing block value) which is not a issue in entry block. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81544/new/

https://reviews.llvm.org/D81544