[PATCH] D81448: [CostModel] Unify Shuffle and InsertElement Costs

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added inline comments.


================
Comment at: llvm/test/CodeGen/SystemZ/splitMove_undefReg_mverifier.ll:213
 CF254:                                            ; preds = %CF254, %CF267, %CF264, %CF240
-  %Shuff113 = shufflevector <2 x i32> %I68, <2 x i32> zeroinitializer, <2 x i32> undef
+  %Shuff113 = shufflevector <2 x i32> %I68, <2 x i32> zeroinitializer, <2 x i32><i32 undef, i32 0>
   %I114 = insertelement <4 x i16> zeroinitializer, i16 27357, i32 3
----------------
samparker wrote:
> dfukalov wrote:
> > If the change is refactoring, why it affects codegen test?
> I think this instruction was just broken, the ShuffleVectorInst class hit an assert on it.
But how it was not asserted before the change? Why change in cost model can change ShuffleVectorInst behavior in codegen test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81448/new/

https://reviews.llvm.org/D81448