[PATCH] D81541: [ObjectYAML][DWARF] Implement the .debug_addr section.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 10 03:47:50 PDT 2020
grimar added inline comments.
================
Comment at: llvm/lib/ObjectYAML/DWARFEmitter.cpp:77
+ if (Format == dwarf::DWARF64) {
+ writeInteger((uint32_t)UINT32_MAX, OS, IsLittleEndian);
+ writeInteger((uint64_t)Length, OS, IsLittleEndian);
----------------
jhenderson wrote:
> `(uint32_t)UINT32_MAX` -> `std::numeric_limits<uint32_t>::max()`
Or, perhaps:
```
writeVariableSizedInteger(UINT32_MAX, 4, OS, IsLittleEndian);
```
(A bit shorter)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81541/new/
https://reviews.llvm.org/D81541
More information about the llvm-commits
mailing list