[PATCH] D81239: Correctly report modified status for DataFlowSanitizer

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 03:14:18 PDT 2020


vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:814
 
   if (!GetArgTLSPtr) {
     Type *ArgTLSTy = ArrayType::get(ShadowTy, 64);
----------------
serge-sans-paille wrote:
> vitalybuka wrote:
> > maybe always true after this point?
> only if the globals don't already exist.
initializeCallbackFunctions  and initializeRuntimeFunctions also changes the module
and even without inserting globals it change setThreadLocalMode



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81239/new/

https://reviews.llvm.org/D81239





More information about the llvm-commits mailing list