[PATCH] D81542: [ObjectYAML][test] Add test cases for the DWARF64 .debug_addr section.

Wed Jun 10 03:14:10 PDT 2020

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

This LGTM. A minor suggestion is inline.

================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-addr.yaml:384
+##                         |                          +--- version (2-byte)
+##                         +------------------------- a1) unit_length (DWARF64, 12-byte)
+##
----------------
At first I wanted to write that 0xffffffff is not a length, but a special mark, but
DWARF spec says "an initial length field is 12 bytes in size", so this seems fine.
Perhaps I'd mention that 0xffffffff is a special part though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81542/new/

https://reviews.llvm.org/D81542