[PATCH] D81469: [DebugInfo/DWARF] - Report .eh_frame sections of version != 1.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 02:08:59 PDT 2020


grimar added a comment.

In D81469#2082410 <https://reviews.llvm.org/D81469#2082410>, @probinson wrote:

> If the .eh_frame section contains contributions for multiple compilation units, the dumper should skip over the bad one and continue dumping at the next one.  In which case, you'd need only one test, with multiple units in it (imitating a linked executable).


Sounds reasonable.

But `Error DWARFDebugFrame::parse(DWARFDataExtractor Data)` returns errors for a few cases already,
e.g. for the case when something is wrong with the augmentation string. Instead it could provide a way to
report a warning (perhaps a warning callback) and continue dumping.

Reimplementing the `DWARFDebugFrame::parse()` to support warnings should be done independently from this change I think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81469/new/

https://reviews.llvm.org/D81469





More information about the llvm-commits mailing list