[PATCH] D81237: Correctly report modified status for SimplifyCFG and LoopSimplify
    Jay Foad via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Jun 10 02:08:56 PDT 2020
    
    
  
foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.
LGTM except for the minor comments inline.
================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2765
     }
+    Changed = true;
 
----------------
This seems like an odd place to put this line. Maybe move it up, right next to the "FOLDING BRANCH TO COMMON DEST" message? That's when we know we're going to change something.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81237/new/
https://reviews.llvm.org/D81237
    
    
More information about the llvm-commits
mailing list