[PATCH] D81156: [Support] Add stream tie function and use it for errs()

Wed Jun 10 02:08:56 PDT 2020

jhenderson added a comment.

In D81156#2084273 <https://reviews.llvm.org/D81156#2084273>, @sammccall wrote:

> In D81156#2084209 <https://reviews.llvm.org/D81156#2084209>, @jhenderson wrote:
>
> > In D81156#2084176 <https://reviews.llvm.org/D81156#2084176>, @sammccall wrote:
> >
> > > This is surprising and unsafe behaviour. Can we reconsider changing the default, at least until a more careful audit of the places errs() is used?
> > >  In particular, if errs is used from multiple threads (with a lock) and outs is used from a single thread (so no lock needed) then this introduces racy flushes to outs() concurrent with writes.
> >
> >
> > Thanks for highlighting this, it's been brought up on D81525 <https://reviews.llvm.org/D81525> as well, so rather than discuss it in two places, we'll look at it there, if that's okay?
>
>
> Happy to discuss there. It's a separate issue though, the discussion there is about initialization being racy,

Yeah, I realised that after posting that previous post, sorry! Still, probably best to keep the discussion in one place for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81156/new/

https://reviews.llvm.org/D81156