[PATCH] D81515: [llvm] Release-mode ML InlineAdvisor

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

If there's some standardized binary format for models, that's might be okay?  By analogy, there are some PNG files in the documentation; we don't insist people use XPM or something like that.  There are some technical reasons to prefer text, though: it would allow someone to identify or diff the contents of the files without specialized tools.

I'm more concerned about adding an opaque matrix of coefficients nobody can reproduce into the codebase.  I think before we commit a generated model, the training tool needs to be committed, and someone needs to verify they can independently reproduce the generated model using that tool.  I think it's important we set the right precedent here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81515/new/

https://reviews.llvm.org/D81515