[PATCH] D81156: [Support] Add stream tie function and use it for errs()

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 10 00:30:31 PDT 2020


sammccall added a comment.

This is surprising and unsafe behaviour. Can we reconsider changing the default, at least until a more careful audit of the places errs() is used?
In particular, if errs is used from multiple threads (with a lock) and outs is used from a single thread (so no lock needed) then this introduces racy flushes to outs() concurrent with writes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81156/new/

https://reviews.llvm.org/D81156





More information about the llvm-commits mailing list