[PATCH] D81422: Change filecheck default to dump input on failure

Tue Jun 9 20:57:27 PDT 2020

mehdi_amini added a comment.

In D81422#2083882 <https://reviews.llvm.org/D81422#2083882>, @arsenm wrote:

> In D81422#2083808 <https://reviews.llvm.org/D81422#2083808>, @mehdi_amini wrote:
>
> > In D81422#2083761 <https://reviews.llvm.org/D81422#2083761>, @arsenm wrote:
> >
> > > I think this is a worse default for development for large tests.
> >
> >
> > Maybe the issue is with large tests that needs to be broken up?
>
>
> This isn't really manageable, especially with the trend of using update_* test checks scripts. Stuff like legalization tests just have to stress every combination of inputs.

This is something that the script generating every combination could manage to split as well?
Alternatively, can these very large test be appended `--dump-input=never` on the RUN line? (maybe the test generator can do this?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422