[PATCH] D80857: [lld-macho] Handle GOT relocations of non-dylib symbols

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

Looks great!



================
Comment at: lld/MachO/Target.h:54
+  // depending on the relocation type. prepareSymbolRelocation() will set up the
+  // GOT/stubs entries, and getDylibSymbolVA() will return the addresses of
+  // those entries.
----------------
getDylibSymbolVA needs to be updated on this line.


================
Comment at: lld/test/MachO/local-got.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o
----------------
int3 wrote:
> MaskRay wrote:
> > `test/ELF/local-got.s` may not be the best name
> > 
> > If you can think of a better name, use that.
> I'm fine with the current name...
How about got-reloc-for-local-symbol?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80857/new/

https://reviews.llvm.org/D80857