[PATCH] D81446: [llvm][ELF][AArch64] Handle R_AARCH64_PLT32 relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Looks great! But you'll need thumb-ups from Peter(s)



================
Comment at: llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:406
+           static_cast<int64_t>(Result) <= INT32_MAX);
+    write(isBE, TargetPtr, static_cast<uint32_t>(Result & 0xffffffffU));
+    break;
----------------
(& 0xffffffffU) seems to be redundant.


================
Comment at: llvm/test/MC/AArch64/elf-reloc-plt32.s:9
+// CHECK:      Section ({{.*}}) .rela.data
+// CHECK-NEXT: 0x0 R_AARCH64_PLT32 extern_func 0x4
+// CHECK-NEXT: }
----------------
Indent by 2 spaces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81446/new/

https://reviews.llvm.org/D81446