[PATCH] D80406: [LLD][ThinLTO] A switch to allow compilation of only one module.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-single-module.ll:29
+;
+;; Multiple --thinlto-single-module uses should result in a combination of inputs compiled. 
+; RUN: ld.lld main.o thin.a --thinlto-single-module=main.o --thinlto-single-module=thin2.o --lto-obj-path=single4.o
----------------
This line has trailing whitespace.


================
Comment at: lld/test/ELF/lto/thinlto-single-module.ll:41
+; RUN: ls main.o.thinlto.bc
+; RUN: not ls thin.*.thinlto.bc
+
----------------
MaskRay wrote:
> Move `IDX` lines here.
> 
> ```
> ; FileCheck %s --check-prefix=IDX < single5.idx
> ; count 1 < single5.idx
> 
> ; IDX: main.o
> ```
> not ls thin.*.thinlto.bc

This does not work when nullglob is enabled for your shell. Consider `RUN: ls | FileCheck --implicit-check='...' /dev/null`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80406/new/

https://reviews.llvm.org/D80406