[PATCH] D81495: [SVE] Remove invalid calls to VectorType::getNumElements from BasicTTIImpl
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 9 13:14:36 PDT 2020
efriedma added a comment.
I agree it makes sense to keep the TargetTransformInfo API as-is; we almost certainly want it to take a generic VectorType.
I'm not sure the `FIXME_ScalableVectorNotSupported` thing is useful here, as opposed to just writing `cast<FixedVectorType>()`. Most of these default cost implementations are working under the assumption that it makes sense to scalarize the operation, and estimating costs based on that. That's not generally useful for scalable vectors, and I suspect that we're just going to override all these methods in the AArch64 target, rather than try to fix the target-independent cost estimation. (At least in the short term.) If we do end up crashing anyway, it should be obvious why it's happening.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81495/new/
https://reviews.llvm.org/D81495
More information about the llvm-commits
mailing list