[PATCH] D81429: [COFF] Port CallGraphSort to COFF from ELF
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 9 13:14:27 PDT 2020
MaskRay added inline comments.
================
Comment at: lld/Common/CallGraphSort.cpp:187
+ DenseMap<const T *, int> orderMap;
+ int curOrder = INT_MIN;
for (int leader : sorted)
----------------
Why is it `INT_MIN` now?
================
Comment at: lld/include/lld/Common/CallGraphSort.h:15
+
+using namespace llvm;
+
----------------
Avoid `using namespace` in a header file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81429/new/
https://reviews.llvm.org/D81429
More information about the llvm-commits
mailing list