[PATCH] D81422: Change filecheck default to dump input on failure

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/dump-input-enable.txt:77
 ;--------------------------------------------------
-; Check no -dump-input, which defaults to never.
 ;--------------------------------------------------
----------------
The previous section already covers `-dump-input=never`. This section was covering the case where `-dump-input` isn't specified.  Maybe you should just update it to check that the default is now `fail` instead of `never`.


================
Comment at: llvm/test/FileCheck/lit.local.cfg:42
 #   ; RUN: %ProtectFileCheckOutput FILECHECK_OPTS=-v \
 #   ; RUN: FileCheck -input-file %s %s 2>&1 \
 #   ; RUN: | FileCheck -check-prefix TRACE %s
----------------
Please add `-dump-input=never` to this first FileCheck call.  Otherwise, the example is broken because FileCheck never prints `expected string found in input` when `-dump-input=fail` regardless of `-v`.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:117
-             "FILECHECK_DUMP_INPUT_ON_FAILURE environment variable.\n"
-             "This option is deprecated in favor of -dump-input=fail.\n"));
 
----------------
jdenny wrote:
> Please mention in the patch summary that `-dump-input-on-failure` and `FILECHECK_DUMP_INPUT_ON_FAILURE` are being dropped.
This is marked as done, but I don't see the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81422/new/

https://reviews.llvm.org/D81422