[PATCH] D81461: GlobalISel: Fix double printing new instructions in legalizer

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added a comment.

In D81461#2082149 <https://reviews.llvm.org/D81461#2082149>, @arsenm wrote:

> It seems both the MachineFunction and MachineIRBuilder have insertion observers; this seems redundant. I think the machine function observers should be removed?


MachineFunction observers are useful even if instructions are built without MIRBuilders (say using BuildMI) so CSE can be aware of it. Similar for deletions. To me, since the MF observer is always called, the one in MachineIRBuilder seems redundant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81461/new/

https://reviews.llvm.org/D81461