[PATCH] D59553: [WIP][LLD][ELF][DebugInfo] Use predefined value to mark debug address ranges pointing to deleted code.

Tue Jun 9 08:13:45 PDT 2020

dblaikie added a comment.

In D59553#2081583 <https://reviews.llvm.org/D59553#2081583>, @jhenderson wrote:

> In D59553#2080726 <https://reviews.llvm.org/D59553#2080726>, @dblaikie wrote:
>
> > In D59553#2080495 <https://reviews.llvm.org/D59553#2080495>, @avl wrote:
> >
> > > > Yeah, I just worry then it becomes another source of inconsistency between consumers/producers/etc. Perhaps we could name it in some way that's clear that it might be removed later - to encourage people to either reach out to us to explain their use case, or to invest a bit more in working with the new default behavior.
> > >
> > > --dead-reloc-obsolete-addend
> > >
> > > or
> > >
> > > --dead-reloc-obsolete
> > >
> > > ? (yes/no option).
> >
> >
> > Not really sure - sometimes flags use the word "experimental" but that more sounds like it might become a real flag in the future, whereas the hope is that it's the other direction. The only other mechanism I've seen is the really verbose flag " -enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang" - but I don't think that's really necessary here. Probably "experimental" (eg: --experimental-dead-reloc (I think 'experimental' usually goes at the start - but you could check other flags for inspiration)) is enough, if we are going to have a flag at all.
>
>
> How about we just go with the basic `--dead-reloc-addend` (or similar) with no `experimental` or `obsolete` in the name? In that case, I'd make it hidden, so users can't find it in the normal help text, and add comments both in the help text (for --help-hidden, and comments in the code) and in the release notes saying it is intended as a chicken switch for compatibility reasons, and that they should contact the LLVM community if the switch is ever actually needed, but if we don't hear we will remove it in the future.

Not sure how many people discover these things by reading the manual or release notes - once it's on a stackoverflow post all context other than the name is probably lost.

But I don't feel too strongly about this if everyone else doesn't.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59553/new/

https://reviews.llvm.org/D59553