[PATCH] D81238: Correctly report modified status for HWAddressSanitizer

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 9 07:39:42 PDT 2020


serge-sans-paille marked 3 inline comments as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:1088
 
   LLVM_DEBUG(dbgs() << "Function: " << F.getName() << "\n");
 
----------------
vitalybuka wrote:
> maybe do not bother with Changed and after this point always return true?
It's possible that `AllocasToInstrument` ends up being empty, or `AllocaToPaddedAllocaMap` is empty, or `OperandsToInstrument` is non empty but with a mask that make all instrumentation fail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81238/new/

https://reviews.llvm.org/D81238





More information about the llvm-commits mailing list