[PATCH] D80716: [AArch64]: BFloat Load/Store Intrinsics&CodeGen

Tue Jun 9 07:39:41 PDT 2020

LukeGeeson added a comment.

In D80716#2074883 <https://reviews.llvm.org/D80716#2074883>, @stuij wrote:

> In D80716#2073251 <https://reviews.llvm.org/D80716#2073251>, @LukeGeeson wrote:
>
> > Besides from rebasing to get @pratlucas changes upstream.
> >
> > @stuij  please could you confirm if you are happy with this, so I can merge
>
>
> Hi Luke,
>
> For the backend tests it would be good if you would use `CHECK-NEXT` from label to ret, like I believe you did in the other patch, using `-asm-verbose=0` to get rid of the cruft.

Similar to my other comment in the [[ https://reviews.llvm.org/D80752 | other  ]]patch:

This isn't how to get rid of `kill` statements. In particular if you pass `-asm-verbose=0` to `llc` in the `RUN` statement then no `CHECK`s are generated, let alone `kill` statements.

Instead to get this desired result you run `llc` without that argument, and then manually remove these unnecessary `kill` lines. This is what I have done and this should fix this. Patch incoming

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80716/new/

https://reviews.llvm.org/D80716